Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move personal user settings page to Vue #4388

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Refactor: Move personal user settings page to Vue #4388

merged 1 commit into from
Jan 21, 2025

Conversation

codewithvk
Copy link
Collaborator

  • Resolves: #
  • Target version: main

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@codewithvk codewithvk force-pushed the private/codewithvk/user_settings_vue_migration branch from 1ff6a91 to ca586cb Compare January 16, 2025 09:12
@codewithvk codewithvk force-pushed the private/codewithvk/user_settings_vue_migration branch from ca586cb to c202b79 Compare January 16, 2025 13:15
@codewithvk codewithvk force-pushed the private/codewithvk/user_settings_vue_migration branch from c202b79 to 5fcfc07 Compare January 16, 2025 16:48
elzody
elzody requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I was being a bit picky here, but I made a few comments and suggestions. If you need any help don't hesitate to ask

templates/personal.php Outdated Show resolved Hide resolved
templates/personal.php Outdated Show resolved Hide resolved
src/personal.js Outdated Show resolved Hide resolved
src/components/PersonalSettings.vue Outdated Show resolved Hide resolved
src/components/PersonalSettings.vue Outdated Show resolved Hide resolved
@codewithvk codewithvk force-pushed the private/codewithvk/user_settings_vue_migration branch 2 times, most recently from 1b32389 to 0084cd6 Compare January 17, 2025 09:35
@codewithvk codewithvk requested a review from elzody January 17, 2025 09:39
elzody
elzody approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing left before merging is to fix the failing test, which you can likely do by just running composer run cs:fix and committing the changes.

@codewithvk codewithvk force-pushed the private/codewithvk/user_settings_vue_migration branch from 0084cd6 to b561d82 Compare January 18, 2025 06:23
@codewithvk codewithvk force-pushed the private/codewithvk/user_settings_vue_migration branch from b561d82 to 3572c8b Compare January 18, 2025 06:40
@elzody elzody merged commit 7cc9043 into nextcloud:main Jan 21, 2025
73 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody elzody approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr juliusknorr is a code owner

Assignees
No one assigned
Labels
2. developing Work in progress feedback-requested technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codewithvk @juliusknorr @elzody